fix: validate region parameter before URL interpolation to prevent SSRF#5819
Open
lucasjia-aws wants to merge 2 commits intoaws:masterfrom
Open
fix: validate region parameter before URL interpolation to prevent SSRF#5819lucasjia-aws wants to merge 2 commits intoaws:masterfrom
lucasjia-aws wants to merge 2 commits intoaws:masterfrom
Conversation
lucasjia-aws
force-pushed
the
fix/validate-region-ssrf-prevention
branch
from
2544331 to
524545d
Compare
- Replace invalid test region "testregion" with valid AWS region "us-west-2" in profiler_app tests and tensorboard tests - Add comprehensive region_validation test suite covering all known AWS regions - Add tests for SSRF payload rejection and malformed region string handling - Add tests for endpoint URL validation against AWS domains - Ensure region validation regex accepts all legitimate AWS regions and rejects malicious inputs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
SDK constructs endpoint URLs by interpolating the region parameter directly into URL strings without validation. A malicious region value can cause requests to be redirected to non-AWS hosts.
Fix:
Added a centralized region_validation module with strict regex validation for region format, and applied
validate_region()at all affected endpoint URL construction sites acrosssagemaker-core,sagemaker-serve, andsagemaker-train.Added
test_region_validation.pywith parametrized tests covering all known AWS regions and invalid/malicious inputs